On 2015-04-14 07:37:30 +0200, Anton Khirnov wrote: > Quoting Janne Grunau (2015-04-13 21:16:33) > > On 2015-04-12 21:14:27 +0200, Anton Khirnov wrote: > > > We want to update it for all the thread contexts, not just the main one. > > > > I don't see how this patch makes a difference. it might just be a > > -ETOOMANYOUTSTANDINGPATCHES but if the comment above means frame thread > > contexts it makes no sense. For slice thread contexts it makes no sense > > either. > > > > Yes, it means frame threading and I think it does make sense. > > Currently when the bit depth and/or chroma format change, the > H264Context values only get updated in the thread where the change > occured, not in any other threads. It does not seem to me that this is > correct behaviour. > > In the context of this set, this is required for 5/6 to work, since > there is no longer a memcpy of the whole H264Context.
ah, makes sense now. patch ok. The comment is still misleading though. Please mention the removed memcpy in update_thread_context Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
