On Tue, Apr 14, 2015, at 17:59, Martin Storsjö wrote: > On Tue, 14 Apr 2015, Luca Barbato wrote: > > > On 14/04/15 10:58, Thomas Guillem wrote: > >> ping ? > >> > > > > The patch seems fine, Justin do you have an opinion? > > I'm not familiar with the flac parser, but I do remember the ML thread > back when it was added in 2010. > > What does this change behaviour-wise - i.e. does seeking still work? When > seeking doesn't get to a frame-aligned position, but starts somewhere, > and > parses forward until it gets to something that seems like a frame > boundary > that can be parsed properly.
Yes, seek still works, I've tested it with avplay. The fifo_buf is allocated with a size of (FLAC_MIN_HEADERS + 3) * FLAC_AVG_FRAME_SIZE, so it can contain approximately 13 flac headers. So even when you seek at a non aligned position, you'll have enough fifo space to get a full flac header. > > // Martin > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
