Quoting Martin Storsjö (2015-04-29 17:01:53) > --- > The input option handling probably isn't quite right. This probably > also should have some documentation somewhere? > ---
I am mostly fine with this patch as it is as an initial implementation (+some docs) and I agree that it should be enabled by default. It should also be a per-stream option I think. Also, we currently send this side data to the decoder, where it typically gets turned into frame side data and survives to filters, or possibly even the muxer. That should not happen if we already applied the rotation. Another thing we should keep in mind for the future is that the rotation side data can also be present on the codec level or the packet level -- the former is suported by h264 and hevc (but probably not used in the wild much or at all), the latter is only theoretical for now, but would make sense (since you don't necessary keep your phone oriented the same way while recording). -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
