On Sat, May 2, 2015 at 10:04 AM, Anton Khirnov <[email protected]> wrote: > Quoting Luca Barbato (2015-05-02 10:16:36) >> On 02/05/15 09:12, Anton Khirnov wrote: >> > This reverts commit 63be97ec403023fb664798432acedaf6e6922527. >> > >> > All those calls were unchecked on purpose, as explained in the comments >> > in the code. >> >> Would be nicer to do something like this: >> >> ret = av_expr_parse_and_eval() >> >> if (ret == AVERROR(ENOMEM) >> goto eval_fail; >> >> at least (no idea about the cases in which you have EINVAL). >> > > This just makes the code more complex for no gain IMO. If we really are > out of memory, it will just fail immediately below.
Your solution is fine, thanks for taking care of it. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
