Hi. I suspect that this bug affects you too, so in the spirit of cooperation
here is the mail I sent about to ffmpeg-devel.


----- Forwarded message from Nicolas George <[email protected]> -----

Reply-To: FFmpeg development discussions and patches <[email protected]>
Date: Wed, 6 May 2015 11:55:25 +0200
From: Nicolas George <[email protected]>
To: FFmpeg development discussions and patches <[email protected]>
Subject: Re: [FFmpeg-devel] Exact screen size not working: Re: [PATCH] Fix 
segfault with x11grab when switching windows.

Le septidi 17 floréal, an CCXXIII, davidpbrown a écrit :
> tldr; Using exact screen size doesn't work but less one pixel does.

The attached patch should fix this.

Please feel anyone free to apply without waiting on me.

davidpbrown: in the future, remember that bug reports should go to the users
mailing list or the issue tracker, unless they are accompanied by a patch.

Regards,

-- 
  Nicolas George

From 9a26eec2aea97aac3c78a943c76d5bc2334cd8bf Mon Sep 17 00:00:00 2001
From: Nicolas George <[email protected]>
Date: Wed, 6 May 2015 11:53:19 +0200
Subject: [PATCH] lavd/xcbgrab: fix comparison with screen size.

Signed-off-by: Nicolas George <[email protected]>
---
 libavdevice/xcbgrab.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c
index 15512cd..166575c 100644
--- a/libavdevice/xcbgrab.c
+++ b/libavdevice/xcbgrab.c
@@ -533,8 +533,8 @@ static int create_stream(AVFormatContext *s)
     gc  = xcb_get_geometry(c->conn, c->screen->root);
     geo = xcb_get_geometry_reply(c->conn, gc, NULL);
 
-    if (c->x + c->width >= geo->width ||
-        c->y + c->height >= geo->height) {
+    if (c->x + c->width > geo->width ||
+        c->y + c->height > geo->height) {
         av_log(s, AV_LOG_ERROR,
                "Capture area %dx%d at position %d.%d "
                "outside the screen size %dx%d\n",
-- 
2.1.4





_______________________________________________
ffmpeg-devel mailing list
[email protected]
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


----- End forwarded message -----

Attachment: signature.asc
Description: Digital signature

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to