On 07/05/15 03:05, Luca Barbato wrote: > On 07/05/15 02:46, Vittorio Giovara wrote: >> From: "Shiina, Hideaki" <[email protected]> >> >> The header had a wrong version description. >> >> Bug-Id: 808 >> Signed-off-by: Shiina Hideaki <[email protected]> >> --- >> libavcodec/mjpegenc_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/mjpegenc_common.c b/libavcodec/mjpegenc_common.c >> index b1f2c00..4df6aa7 100644 >> --- a/libavcodec/mjpegenc_common.c >> +++ b/libavcodec/mjpegenc_common.c >> @@ -98,7 +98,7 @@ static void jpeg_put_comments(AVCodecContext *avctx, >> PutBitContext *p) >> put_marker(p, APP0); >> put_bits(p, 16, 16); >> avpriv_put_string(p, "JFIF", 1); /* this puts the trailing zero-byte >> too */ >> - put_bits(p, 16, 0x0201); /* v 1.02 */ >> + put_bits(p, 16, 0x0102); /* v 1.02 */ >> put_bits(p, 8, 0); /* units type: 0 - aspect ratio */ >> put_bits(p, 16, avctx->sample_aspect_ratio.num); >> put_bits(p, 16, avctx->sample_aspect_ratio.den); > > > = X'0102' > The most significant byte is used for major revisions, the least > significant byte for minor revisions. Version 1.02 is the current > released revision. > > Maybe > > put_marker(p, APP0); > put_bits(p, 16, 16); > avpriv_put_string(p, "JFIF", 1); /* this puts the trailing > zero-byte too */ > - put_bits(p, 16, 0x0201); /* v 1.02 */ > + ptr = put_bits_ptr(p) > + put_bits(p, 16, 0); /* v 1.02 */ > + AV_WB16(ptr, 0x0102); > put_bits(p, 8, 0); /* units type: 0 - aspect ratio */ > put_bits(p, 16, avctx->sample_aspect_ratio.num); > put_bits(p, 16, avctx->sample_aspect_ratio.den); >
To make it more evident? (since should be the same as the version we have...) _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
