On Thu, 7 May 2015, Alexandra Hájková wrote:
The old one is the result of the reverse engineering and guesswork.
The new one has been written following the now-available specification.
This work is part of Outreach Program for Women Summer 2014 activities
for the Libav project.
The fate references had to be changed because the old demuxer truncates
the last frame in some cases, the new one handles it properly.
The seek-test reference is changed because seeking works differently
in the new demuxer. When seeking, the packet is not read from the stream
directly, but it is rather constructed by the demuxer. That is why
position is -1 now in the reference.
---
anotation:
Amended patch is the response to the last Anton's review.
Index Object (also other objects after the Data) is beeing processed after
Data are skipped as told in the comment before while in read_header.
Some rebasing mistakes were removed.
In general, if at all possible (or unless it's trivial), please reply to
every single one of the mails that reviewed your patch, and reply to every
single comment in them, saying "Yes, will do" or "Done" or "No, I don't
think so, because ..."
Don't just say "I did everything that N.N. told me to do", because as we
have seen so far, even if one thinks one has done "everything" something
can easily be missed. If you take the time to actually respond to the
review itself, you will have a great opportunity to both you yourself
verify that you indeed have taken care of all of the points raised, or ask
for clarification.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
