Rémi Denis-Courmont wrote: > Of course, the kernel buffers need to be large enough to cope with packet > bursts, but that is not directly related to the bit rate.
While I fully agree that using the kernel receive buffer *instead of* a user one is a hack at best, I think you either misunderstood what the patch is intended to fix (as I understand it) or underestimate how small the forced default 64K is. In case you missed it, libav forces the receive buffer size to 64K (or buffer_size) overriding whatever size the OS wanted. To the best of my knowledge every modern/non-embedded OS/distro I can think of uses a much higher default value. It really doesn't take a whole lot of jitter to throw it off, and while there's little correlation between packet bursts and bitrate, higher bitrates don't exactly help. I don't think it's a good idea to expect users to change this value to something sane just to get it to work as expected. My position is thus; 1) It's best to leave it alone unless the user explicitly sets it, but if you're going to force it, don't force it to something painfully low like 64K. 2) Failing to set a setting to the specified value should not fail silently, it should either fail loudly or fail loudly and fall back to the best it can do. Regards, John Högberg _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
