On 19/05/15 16:07, Diego Biurrun wrote:
> On Wed, May 13, 2015 at 01:46:50PM +0200, Luca Barbato wrote:
>> --- a/arch.mak
>> +++ b/arch.mak
>> @@ -5,6 +5,7 @@ OBJS-$(HAVE_VFP) += $(VFP-OBJS) $(VFP-OBJS-yes)
>> OBJS-$(HAVE_NEON) += $(NEON-OBJS) $(NEON-OBJS-yes)
>>
>> OBJS-$(HAVE_ALTIVEC) += $(ALTIVEC-OBJS) $(ALTIVEC-OBJS-yes)
>> +OBJS-$(HAVE_VSX) += $(VSX-OBJS) $(VSX-OBJS-yes)
>
> vertical alignment
>
>> OBJS-$(HAVE_MMX) += $(MMX-OBJS) $(MMX-OBJS-yes)
>> OBJS-$(HAVE_YASM) += $(YASM-OBJS) $(YASM-OBJS-yes)
>> --- a/libavutil/ppc/float_dsp_altivec.c
>> +++ b/libavutil/ppc/float_dsp_altivec.c
>> @@ -98,7 +98,7 @@ void ff_vector_fmul_reverse_altivec(float *dst, const
>> float *src0,
>> const float *src1, int len)
>> {
>> int i;
>> - vec_f d, s0, s1, h0, l0, s2, s3
>> + vec_f d, s0, s1, h0, l0, s2, s3;
>> vec_f zero = (vec_f)vec_splat_u32(0);
>
> Looks like an unrelated bug fix for a previous patch.
>
>> --- a/libavutil/ppc/float_dsp_init.c
>> +++ b/libavutil/ppc/float_dsp_init.c
>> @@ -24,18 +24,26 @@
>> av_cold void ff_float_dsp_init_ppc(AVFloatDSPContext *fdsp, int bit_exact)
>> {
>> - if (!PPC_ALTIVEC(av_get_cpu_flags()))
>> - return;
>
> IIUC VSX implies AltiVec, so this check could remain.
>
> Diego
>
>> + if (HAVE_BIGENDIAN && PPC_ALTIVEC(av_get_cpu_flags())) {
>> + fdsp->vector_fmul = ff_vector_fmul_altivec;
>> + fdsp->vector_fmul_add = ff_vector_fmul_add_altivec;
>> + fdsp->vector_fmul_reverse = ff_vector_fmul_reverse_altivec;
>>
>> + if (!bit_exact) {
>> + fdsp->vector_fmul_window = ff_vector_fmul_window_altivec;
>> + }
>> + }
>> + if (PPC_VSX(av_get_cpu_flags())) {
>> + fdsp->vector_fmul = ff_vector_fmul_vsx;
>> + fdsp->vector_fmul_add = ff_vector_fmul_add_vsx;
>> + fdsp->vector_fmul_reverse = ff_vector_fmul_reverse_vsx;
>> +
>> + if (!bit_exact) {
>> + fdsp->vector_fmul_window = ff_vector_fmul_window_vsx;
>> + }
>
> You could align the = while you're at it.
>
You are reviewing a superseded set.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
