On 20/05/15 13:21, Diego Biurrun wrote:
> On Wed, May 20, 2015 at 02:08:55AM +0100, Vittorio Giovara wrote:
>> Add an helper function and a compatibility layer for exporting
>
> a helper
>
>> --- a/doc/APIchanges
>> +++ b/doc/APIchanges
>> @@ -13,6 +13,10 @@ libavutil: 2014-08-09
>>
>> +2015-xx-xx - xxxxxxx - lavc 56.25.0 - avcodec.h
>> + Add AV_PKT_DATA_CODING_PARAMS and to carry AVPacket compression parameters
>
> s/and//
>
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -853,6 +853,23 @@ typedef struct AVPanScan{
>> + /**
>> + * Quality after compression, between 1 (good) and FF_LAMBDA_MAX (bad).
>> + */
>> + int quality;
>
> Is there a reason for this to be signed when it's supposed to carry only
> unsigned values?
If we keep 0 for unknown probably not. If we use 0 for unknown and -1
for not-applicable then might have sense but should be documented
nonetheless.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
