On Sat, 23 May 2015, Niels Möller wrote:
Hendrik Leppkes <[email protected]> writes:
I'd rather reimplement small light crypto primitives when needed if you
are thinking about them.
First Rule of Crypto: Don't roll your own.
I'm not sure what crypto libav needs, but if it's basic stuff like,
e.g., aes, sha1, and hmac, it should be no big deal to have wrapper
functions invoking either openssl or nettle depending on the
configuration. (Nettle is the library which current gnutls uses for the
lower-level crypto, and which I happen to be the main author of).
We already do have that actually, see libavformat/rtmpdh.* (for a
diffie-hellman handshake), supporting nettle+gmp, gcrypt (for the cases
when you use a really old gnutls) and openssl.
For really basic things like md5, sha1, hmac and aes, we have native
implementations - and I'm not too worried about using our own
implementation for them - but for other things I fully agree with Hendrik.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel