On 25/05/15 20:55, Rémi Denis-Courmont wrote:
Le lundi 25 mai 2015, 20:42:58 Luca Barbato a écrit :
On 25/05/15 13:51, Rémi Denis-Courmont wrote:
Le 2015-05-25 14:44, Luca Barbato a écrit :
On 25/05/15 13:37, Rémi Denis-Courmont wrote:
How does that justify falling back to High when CBP is requested? And
ditto for CHP since you brought it up.
Issuing an error and going out instead of a warning sounds better?
IMHO, an encoder output:
- MUST obey the requested constraints,
- SHOULD leverage as many codec feature as the requested constraints
permit.
So you cannot upgrade CBP or CHP to HP.
I presume that NVENC's BP is actually H264's CBP. It's very unlikely
that the non-constrained features of BP would be used: the resulting
output would not conform to MP/HP.
Btw right now it just accepts main, high and baseline as input and
rejects anything else.
That is not how I read the patch... It seems to me it´s falling back to High
for all except Baseline and Main.
The setting is done through a private option, the private option
enumerates 3 supported values that I mapped to the FF_PROFILE matching
them since I wasn't creative enough to do an
enum {
NVENC_MAIN, NVENC_HIGH, NVENC_BASELINE
}
and use it. I guess it is confusing enough to warrant using something
different.
IMO, that is terrible: You require selecting BP to get CBP. That punishes with
failure those with a clue who correctly select CBP when they want CBP.
Discuss with the NVENC people, I'd gladly map the option if it existed,
I'll update the patch to use a private enum and expose all the profiles
available instead those commonly used 3.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
