On Tue, May 26, 2015 at 3:10 PM, Vittorio Giovara <[email protected]> wrote: > On Tue, May 26, 2015 at 2:53 PM, Vittorio Giovara > <[email protected]> wrote: >> On Tue, May 26, 2015 at 2:49 PM, Hendrik Leppkes <[email protected]> wrote: >>> On Mon, May 25, 2015 at 9:46 PM, Vittorio Giovara >>> <[email protected]> wrote: >>>> On Sun, May 24, 2015 at 12:12 PM, Luca Barbato <[email protected]> wrote: >>>>> On 24/05/15 10:43, Anton Khirnov wrote: >>>>>> Quoting Vittorio Giovara (2015-05-22 20:50:10) >>>>>>> Code is small enough that there is no advantage in a separate function. >>>>>> >>>>>> And what is the advantage in duplicating this code? >>>>>> >>>>> >>>>> The functions are put in different files later. I wonder if can't be >>>>> possible to share more of it instead. >>>> >>>> Exactly, it's a small code duplication in favor of reorganizing >>>> functions into proper groups. >>> >>> Isnt there a macro for swapping things, or does that not work with >>> this array expression? FFSWAP or something? >>> Might look a bit tidier. >> >> Oh good idea, I'll tidy this up when pushing. > > So the only way I found to make this work FFSWAP() is with a void cast > > // exchange uv > if (dst->avctx->codec_tag == AV_RL32("VCR2")) > FFSWAP(void *, dst->pblocks[4], dst->pblocks[5]); > > would that be still ok? > -- > Vittorio
ok'd by Luca -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
