On Mon, 1 Jun 2015, James Almer wrote:
On 01/06/15 7:54 AM, Martin Storsjö wrote:
This fixes dxva2 detection (i.e. correctly realizes that it isn't
available) for WinRT, where dxva2api.h does exist, but these definitions
are omitted (when targeting the API subsets).
Ideally we should rather check for e.g. DXVA2_ConfigPictureDecode,
but configure might fail to find that definition due to _WIN32_WINNT
not being set to the right value during configure. (libavcodec/dxva2.h
manually overrides the _WIN32_WINNT define.)
Something like
enabled dxva2api_h && check_type "dxva2api.h" DXVA2_ConfigPictureDecode
-D_WIN32_WINNT=0x0600 || disable dxva2api_h
Thanks - I somehow missed that check_type can take other parameters to use
while compiling.
Should work then. You can put it above the d3d11_cobj check (Which IMO should
be removed alongside the d3d11va_lib
check until actual d3d11 support is added to avconv, for that matter).
I see this patch was committed already, so up to you if you prefer the above
solution or not.
This does sound better indeed (and I agree about removing the extra d3d11
things for avconv support which isn't there yet).
Although I think it's a bit more straightforward to just add this as an
unconditional check_type call without intermixing it with
enabling/disabling dxva2api_h though.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
