On Sun, Jun 28, 2015 at 7:47 AM, Luca Barbato <[email protected]> wrote: > On 28/06/15 02:05, Vittorio Giovara wrote: >> Partially based on code by Marton Balint and Kieran Kunhya. >> >> Signed-off-by: Vittorio Giovara <[email protected]> >> --- >> libavcodec/h264.c | 10 ++++++++++ >> libavcodec/h264.h | 8 ++++++++ >> libavcodec/h264_sei.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >> libavcodec/version.h | 2 +- >> 4 files changed, 67 insertions(+), 1 deletion(-) >> > > Something like this is why I want to have decoupled side-data creation > and binding to frame. > > I have quite a bit of code parsing SEI (and also storing side-data as > SEI for x264) in my personal branches and it is _quite_ problematic have > a structure a field for every possible registered (and unregistered but > interesting) SEI.
Imho is still better to have a single place to initialize them, even if it's very long. if you reeeeeally want a function helper, please make it private. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
