On Wed, Jul 8, 2015 at 8:27 PM, Luca Barbato <[email protected]> wrote: > From: Sebastien Zwickert <[email protected]> > > Avoid possible issues with memmapped hardware buffers in > case VDA is not doing a conversion on behalf of the user > and make the code more proper as working example. > > CC: [email protected] > Signed-off-by: Luca Barbato <[email protected]> > --- > avconv_vda.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/avconv_vda.c b/avconv_vda.c > index 40f87c4..d86076e 100644 > --- a/avconv_vda.c > +++ b/avconv_vda.c > @@ -76,6 +76,8 @@ static int vda_retrieve_data(AVCodecContext *s, AVFrame > *frame) > data, linesize, vda->tmp_frame->format, > frame->width, frame->height); > > + CVPixelBufferUnlockBaseAddress(pixbuf, kCVPixelBufferLock_ReadOnly); > + > ret = av_frame_copy_props(vda->tmp_frame, frame); > if (ret < 0) > return ret; > -- > 1.9.0 >
Patch is OK. Unrelated to that, there really should be standard for the prefixes in the subject line, and I would wager that the majority here would vote for "avconv/vda: ". Inconsistency is evil. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
