On Sat, Jul 11, 2015 at 11:35:44AM +0200, Luca Barbato wrote: > On 11/07/15 00:39, Andreas Cadhalpun wrote: > > Signed-off-by: Andreas Cadhalpun <[email protected]> > > --- > > libavformat/riffdec.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c > > index eebd8ed..be55699 100644 > > --- a/libavformat/riffdec.c > > +++ b/libavformat/riffdec.c > > @@ -106,6 +106,11 @@ int ff_get_wav_header(AVIOContext *pb, AVCodecContext > > *codec, int size, int big_ > > codec->bit_rate = avio_rb32(pb) * 8; > > codec->block_align = avio_rb16(pb); > > } > > + if (codec->bit_rate < 0) { > > + av_log(NULL, AV_LOG_ERROR, > > + "Invalid bit rate: %d\n", codec->bit_rate); > > + return AVERROR_INVALIDDATA; > > + } > > I'm quite sure some codecs do not have a fixed bit_rate while some other > (like the g726 below) do use it. > > So I'd expect this change to break on some semi-valid files and prevent > something horrid in other.
I know how to prevent it in much easier way - RTFM, see that byte rate in WAVEFORMAT is an unsigned number and get back to sleep. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
