On 14/07/15 15:42, wm4 wrote:
> On Tue, 14 Jul 2015 12:36:10 +0200
> Luca Barbato <[email protected]> wrote:
> 
>> On 14/07/15 11:52, wm4 wrote:
>>> You could just remove all this code, and use generic indexing. It's the
>>> only way to get exact seeking with mp3.
>>
>> I can try again on the sample reported to be faulty, do you have a
>> sample that works only with the generic seeking and gets a completely
>> bogus value otherwise?
>>
>> (I have no qualms in dropping this code, I tried to keep it as simple as
>> possible but it still feels too much complexity).
> 
> VBR files can be pretty bad here. The XING index has only 100 entries,
> so it can be off by a lot if the file is long.
> 
> With gapless audio you generally need 100% exact seeking, because
> otherwise you don't know how many samples you should drop from the last
> frames.

Anybody against this approach?

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to