On Mon, Jul 20, 2015 at 8:48 AM, Anton Khirnov <[email protected]> wrote: > Quoting Vittorio Giovara (2015-07-15 19:41:20) >> Allocating coded_frame is what most encoders do anyway, so it makes >> sense to always allocate it in a single place. This bring uniformity to >> encoder behaviour and prevents applications from erroneusly accessing >> this field when not allocated. >> >> Additionally this helps isolating encoders that export information with >> it, and it heavily simplifies its deprecation. >> >> Signed-off-by: Vittorio Giovara <[email protected]> >> --- >> libavcodec/a64multienc.c | 7 ------- >> libavcodec/alacenc.c | 7 ------- >> libavcodec/aliaspixenc.c | 16 ---------------- >> libavcodec/asvenc.c | 18 ++---------------- >> libavcodec/bmpenc.c | 11 ----------- >> libavcodec/cljrenc.c | 17 ----------------- >> libavcodec/dnxhdenc.c | 6 ------ >> libavcodec/dpxenc.c | 11 ----------- >> libavcodec/dvenc.c | 11 ----------- >> libavcodec/ffv1enc.c | 5 ----- >> libavcodec/flashsvenc.c | 8 -------- >> libavcodec/gif.c | 6 ------ >> libavcodec/huffyuvenc.c | 5 +---- >> libavcodec/jpeglsenc.c | 11 ----------- >> libavcodec/lclenc.c | 6 ------ >> libavcodec/libopencore-amr.c | 1 - >> libavcodec/libopenjpegenc.c | 8 -------- >> libavcodec/libschroedingerenc.c | 6 ------ >> libavcodec/libspeexenc.c | 4 ++-- >> libavcodec/libtheoraenc.c | 6 ------ >> libavcodec/libvpxenc.c | 7 ------- >> libavcodec/libx264.c | 6 ------ >> libavcodec/libx265.c | 8 -------- >> libavcodec/libxavs.c | 6 ------ >> libavcodec/libxvid.c | 4 ---- >> libavcodec/ljpegenc.c | 5 ----- >> libavcodec/mpegvideo_enc.c | 3 +-- >> libavcodec/nvenc.c | 6 ------ >> libavcodec/pamenc.c | 11 ----------- >> libavcodec/pcm.c | 11 ----------- >> libavcodec/pcxenc.c | 11 ----------- >> libavcodec/pngenc.c | 11 ----------- >> libavcodec/pnmenc.c | 14 -------------- >> libavcodec/proresenc.c | 5 ----- >> libavcodec/qsvenc.c | 6 ------ >> libavcodec/qtrleenc.c | 8 -------- >> libavcodec/rawenc.c | 11 ----------- >> libavcodec/sgienc.c | 11 ----------- >> libavcodec/sunrastenc.c | 11 ----------- >> libavcodec/svq1enc.c | 4 +--- >> libavcodec/targaenc.c | 11 ----------- >> libavcodec/tiffenc.c | 11 ----------- >> libavcodec/utils.c | 12 ++++++++++-- >> libavcodec/utvideoenc.c | 9 --------- >> libavcodec/v210enc.c | 12 ------------ >> libavcodec/v410enc.c | 15 --------------- >> libavcodec/xbmenc.c | 11 ----------- >> libavcodec/xwdenc.c | 18 ------------------ >> libavcodec/zmbvenc.c | 8 -------- >> 49 files changed, 17 insertions(+), 419 deletions(-) >> >> diff --git a/libavcodec/libspeexenc.c b/libavcodec/libspeexenc.c >> index ec8882f..d4ca45c 100644 >> --- a/libavcodec/libspeexenc.c >> +++ b/libavcodec/libspeexenc.c >> @@ -243,8 +243,8 @@ static av_cold int encode_init(AVCodecContext *avctx) >> below with speex_header_free() */ >> header_data = speex_header_to_packet(&s->header, &header_size); >> >> - /* allocate extradata and coded_frame */ > > I wonder where did this come from. > > The patch looks good to me. Funny how much code still used av_freep > instead of av_frame_free.
nice silver lining, I'll mention this in the commit log -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
