On Mon, Jul 20, 2015 at 2:34 PM, Tom Butterworth <[email protected]> wrote: >> Is this change necessary? There are now two switches that carry out >> the same purpose and the condition above forces cases from both >> switches to perform the same operation. > > Define "necessary" :) > > Setting the tex_rat and tex_fun members to the same value every frame > is redundant. This change sets them once per session rather than every > single frame. > > I considered removing the per-frame switch (which now only sets the > string for the debug log) entirely as this information can be derived > from the four-cc printed in the stream information. Maybe this patch > should indeed remove the per-frame switch and only print the > second-stage compressor (Snappy or none) per-frame?
Yes, I think printing the texture type once now that it can't change midstream is better than per-frame. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
