On Sun, 26 Jul 2015, Hendrik Leppkes wrote:
On Sun, Jul 26, 2015 at 11:57 AM, Martin Storsjö <[email protected]> wrote:
If _WIN32_WINNT is unset, we force it to a new enough value to
make sure the necessary definitions are visible.
When targeting Windows Phone or Windows RT, _WIN32_WINNT should
be at least 0x0602 - otherwise the windows headers themselves
can cause errors (which technically are bugs in the headers).
Raising this value here shouldn't hurt; the alternative would
be to not touch it at all if WINAPI_FAMILY is set to phone/app,
or to force setting it to 0x0602 in configure if unset (for phone/app).
---
libavcodec/d3d11va.h | 2 +-
libavcodec/dxva2.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/d3d11va.h b/libavcodec/d3d11va.h
index 2163b35..5237119 100644
--- a/libavcodec/d3d11va.h
+++ b/libavcodec/d3d11va.h
@@ -32,7 +32,7 @@
#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0600
Shouldnt these checks also be updated to increment it if its 0x0600 right now?
It does indeed look strange this way.
Strictly it shouldn't be needed, but we could do that as well just for
consistency. Or scrap this, and hardcode it to 0x0602 in patch 2/10, but I
see you agree with my reasoning there.
So I can change this to consistently use 0x0602 just to make sure it
doesn't look strange. Perhaps also change configure to test with version
0x0602 for the test where it is overridden?
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
