On Sun, Aug 30, 2015 at 7:10 PM, Martin Storsjö <[email protected]> wrote: > On Sun, 30 Aug 2015, Vittorio Giovara wrote: > >> On Sat, Aug 29, 2015 at 10:33 PM, Martin Storsjö <[email protected]> wrote: >>> >>> On Sat, 29 Aug 2015, Vittorio Giovara wrote: >>> >>>> --- >>>> Related to >>>> >>>> In file included from libavutil/des.h.c:1: >>>> /Users/GiovaraV/src/libav/libavutil/des.h:33:5: warning: >>>> 'FF_API_CRYPTO_CONTEXT' is not defined, evaluates to 0 [-Wundef] >>>> #if FF_API_CRYPTO_CONTEXT >>>> ^ >>>> >>>> Vittorio >>>> >>>> libavutil/des.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/libavutil/des.h b/libavutil/des.h >>>> index 32c2c9a..351fce2 100644 >>>> --- a/libavutil/des.h >>>> +++ b/libavutil/des.h >>>> @@ -23,6 +23,7 @@ >>>> #define AVUTIL_DES_H >>>> >>>> #include <stdint.h> >>>> +#include <version.h> >>>> >>>> /** >>>> * @defgroup lavu_des DES >>>> -- >>>> 1.9.5 (Apple Git-50.3) >>> >>> >>> >>> Ok (although in this case, we should also remember to remove this include >>> again once the deprecation is done). >> >> >> Oh, right, I can add this include inside the FF_API define if that's ok. > > > Isn't that a bit recursive, since you need version.h to be able to evaluate > the FF_API defines?
Oh, of course, never mind that idea, we'll just try to remember at deprecation time... Thanks for the review -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
