On 01/09/15 10:53, Arttu Ylä-Outinen wrote: > > On 2015-08-28 17:41, Luca Barbato wrote: >> On 28/08/15 14:57, Arttu Ylä-Outinen wrote: >>> Signed-off-by: Arttu Ylä-Outinen <[email protected]> >>> --- >>> Changes from v1: >>> - Fix a typo in commit message. >>> - Use pkg-config in configure. >>> - Remove documentation about -thread parameter which didn't >>> actually >>> work. >>> - Replace asserts with proper errors in libkvazaar_encode. >>> - Replace copying pixels in libkvazaar_encode with a call to >>> av_image_copy. I'll update this to avoid the copy when Kvazaar >>> gets >>> support for it. >>> >>> Thanks for the reviews! >> Looks ok to me, beside the >> >>> + av_assert0(written + chunk->len <= len_out); >> That looks a testing leftover. > > I left it in just to be sure we don't write past the buffer even if > there was a bug. > >> I'd test it a bit and push tomorrow if it works as intended and nobody >> found issues I overlooked. > > Did you find any problems?
Just had the travis integration delaying me and the build issue I patched on kvazaar (that lead me to look again at the build script). lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
