On Thu, Sep 10, 2015 at 6:12 PM, Kostya Shishkov <[email protected]> wrote: > On Thu, Sep 10, 2015 at 05:28:22PM +0200, Vittorio Giovara wrote: >> --- >> libavcodec/dct32.h | 2 +- >> libavcodec/hqxdsp.h | 1 - >> libavcodec/mpegutils.h | 2 +- >> libavcodec/pngdsp.h | 2 +- >> libavcodec/twinvq.h | 2 +- >> libavcodec/wma_freqs.h | 2 +- >> 6 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/libavcodec/dct32.h b/libavcodec/dct32.h >> index 110338d..8bf6880 100644 >> --- a/libavcodec/dct32.h >> +++ b/libavcodec/dct32.h >> @@ -22,4 +22,4 @@ >> void ff_dct32_float(float *dst, const float *src); >> void ff_dct32_fixed(int *dst, const int *src); >> >> -#endif >> +#endif /* AVCODEC_DCT32_H */ > > missing comment isn't a typo IMO > >> diff --git a/libavcodec/hqxdsp.h b/libavcodec/hqxdsp.h >> index 163c1f8..2cd2a8e 100644 >> --- a/libavcodec/hqxdsp.h >> +++ b/libavcodec/hqxdsp.h >> @@ -37,4 +37,3 @@ typedef struct HQXDSPContext { >> void ff_hqxdsp_init(HQXDSPContext *c); >> >> #endif /* AVCODEC_HQXDSP_H */ >> - > > This stretches typo definition quite a bit. > >> diff --git a/libavcodec/mpegutils.h b/libavcodec/mpegutils.h >> index 5c503fb..9b5a576 100644 >> --- a/libavcodec/mpegutils.h >> +++ b/libavcodec/mpegutils.h >> @@ -132,4 +132,4 @@ void ff_draw_horiz_band(AVCodecContext *avctx, AVFrame >> *cur, AVFrame *last, >> int y, int h, int picture_structure, int >> first_field, >> int low_delay); >> >> -#endif /* AVCODEC_PICTTYPE_H */ >> +#endif /* AVCODEC_MPEGUTILS_H */ > > That's not a typo but rather a copypaste error. > >> diff --git a/libavcodec/pngdsp.h b/libavcodec/pngdsp.h >> index 98d29a8..607fe64 100644 >> --- a/libavcodec/pngdsp.h >> +++ b/libavcodec/pngdsp.h >> @@ -37,4 +37,4 @@ typedef struct PNGDSPContext { >> void ff_pngdsp_init(PNGDSPContext *dsp); >> void ff_pngdsp_init_x86(PNGDSPContext *dsp); >> >> -#endif /* AVCDODEC_PNGDSP_H */ >> +#endif /* AVCODEC_PNGDSP_H */ > > This one is typo for a change. > >> diff --git a/libavcodec/twinvq.h b/libavcodec/twinvq.h >> index 3148069..3dc0ab4 100644 >> --- a/libavcodec/twinvq.h >> +++ b/libavcodec/twinvq.h >> @@ -200,4 +200,4 @@ int ff_twinvq_decode_frame(AVCodecContext *avctx, void >> *data, >> int ff_twinvq_decode_close(AVCodecContext *avctx); >> int ff_twinvq_decode_init(AVCodecContext *avctx); >> >> -#endif /* AVCODEC_TWINVQ_DATA_H */ >> +#endif /* AVCODEC_TWINVQ_H */ > > Doesn't look like a typo to me. > >> diff --git a/libavcodec/wma_freqs.h b/libavcodec/wma_freqs.h >> index 415c83b..d40ab65 100644 >> --- a/libavcodec/wma_freqs.h >> +++ b/libavcodec/wma_freqs.h >> @@ -23,4 +23,4 @@ >> >> extern const uint16_t ff_wma_critical_freqs[25]; >> >> -#endif /* AVCODEC_WMA_FREQS */ >> +#endif /* AVCODEC_WMA_FREQS_H */ > > Ditto. > > Morale: think more about proper log messages.
How about "Consistently make sure that every header ends with an appropriate comment"? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
