On Fri, Sep 11, 2015 at 12:45 AM, Luca Barbato <[email protected]> wrote: > On 11/09/15 00:17, wm4 wrote: >> Note that convergence_duration had another meaning, one which was in >> practice never used. The only real use for it was a 64 bit replacement >> for the duration field. It's better just to make duration 64 bits, and >> to get rid of it. >> --- >> libavcodec/audio_frame_queue.c | 2 +- >> libavcodec/audio_frame_queue.h | 2 +- >> libavcodec/avcodec.h | 44 >> +++++++++++------------------------------- >> libavcodec/avpacket.c | 6 ++++++ >> libavcodec/parser.c | 2 ++ >> libavcodec/version.h | 3 +++ >> libavformat/framecrcenc.c | 2 +- >> libavformat/matroskadec.c | 6 ++++-- >> libavformat/matroskaenc.c | 8 ++++++-- >> libavformat/md5enc.c | 2 +- >> libavformat/mov.c | 2 +- >> libavformat/r3d.c | 4 ++-- >> libavformat/utils.c | 6 ++++-- >> 13 files changed, 43 insertions(+), 46 deletions(-) >>
Patch looks good. > > Fine for me, that reminds me I want to make AVPacket.size 64bit as well, > this will need additional care and handling and I'd appreciate help. > AVPacket.size directly corresponds to AVBuffers, which have an int size, so changing that would be anything but trivial. And if its changed, please use size_t, as thats the allocation limit anyway, and not unconditional 64-bit. Not sure I see the need personally, though, but not like I would complain. - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
