On Mon, 2015-09-28 at 11:14 +0200, Anton Khirnov wrote: > Quoting John Stebbins (2015-09-25 20:12:48) > > On Fri, 2015-09-25 at 19:49 +0200, Luca Barbato wrote: > > > On 25/09/15 18:25, John Stebbins wrote: > > > > > > > > On Fri, 2015-09-25 at 17:59 +0200, Luca Barbato wrote: > > > > > On 25/09/15 17:36, John Stebbins wrote: > > > > > > elementid != MATROSKA_ID_TAGTARGETS_TRACKUID > > > > > > > > > > This seems unrelated to the commit message. > > > > > > > > > > > > > The commit message specifically calls out "track language" tags. > > > > The > > > > problem I am addressing and had a specific test case for was > > > > language > > > > tags attached to tracks. I could generalize it to filter out > > > > all > > > > "language" tags since it is an invalid tag in general, but I > > > > don't > > > > know > > > > if there are other undocumented uses of this tag. > > > > > > > > > > Ah, ok. > > > > > > Patch in tomorrow if nobody says anything. > > > > > > > > > > I would be fine with amending this to filter all language tags if > > you > > all think this is the right thing to do. I was just unsure. > > I don't see a problem with writing 'language' for chapters, if the > caller wants it. >
Ok. So the patch should be good is it is. Thanks for the feedback.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
