Quoting Luca Barbato (2015-10-01 01:35:18)
> Bug-Id: CID 1320426
> ---
> libavformat/hls.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 467a491..be47207 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -220,9 +220,8 @@ static int url_connect(struct variant *var, AVDictionary
> *opts)
>
> av_dict_copy(&tmp, opts, 0);
>
> - av_opt_set_dict(var->input, &tmp);
> -
> - if ((ret = ffurl_connect(var->input, NULL)) < 0) {
> + if ((ret = av_opt_set_dict(var->input, &tmp)) < 0 ||
> + (ret = ffurl_connect(var->input, NULL)) < 0) {
nit: this syntax is unreadable and prone to errors, use a separate
assignment and a separate if for this.
--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
