Quoting Vittorio Giovara (2015-10-03 14:44:11) > On Sat, Oct 3, 2015 at 2:26 PM, Anton Khirnov <[email protected]> wrote: > > Quoting Vittorio Giovara (2015-10-03 14:22:31) > >> On Sat, Oct 3, 2015 at 1:47 PM, Anton Khirnov <[email protected]> wrote: > >> > Quoting Vittorio Giovara (2015-10-01 00:06:30) > >> >> This silence a few warnings and matches more closely av_image_*: > >> >> - avpicture_fill() reads a const pointer > >> >> - avpicture_layout() uses uint8_t instead of unsigned char > >> >> > >> >> Signed-off-by: Vittorio Giovara <[email protected]> > >> >> --- > >> > > >> > Doesn't this produce new warnings, since you're assigning const ptr to > >> > non-const data? > >> > >> where do you mean? av_image_fill_arrays() takes a const pointer, and > >> assigning a non-const pointer to a const pointer should be fine, no? > > > > Ah, so the warning is in av_image_fill_arrays() instead. That is so much > > better. > > it's *also*, not instead. I can hold off on this one if you prefer.
I just don't see a point in shuffling the warnings around. And specifically this seems a step in the wrong direction, since in the end what you always have to do is assign ptr plus some offset to the data[] array. And data[] has to be non-const. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
