On Tue, Oct 6, 2015 at 7:35 PM, Luca Barbato <[email protected]> wrote:
> On 06/10/15 22:41, Sean McGovern wrote: > > On Mon, Oct 5, 2015 at 5:19 PM, Sean McGovern <[email protected]> > wrote: > > > >> The versioning facility in the Solaris linker differs from Linux in 3 > ways: > >> > >> 1. It does not support globs in linker scripts for > >> symbol versioning -- this is a GNU extension. > >> > >> 2. The linker argument is '-M', instead of '--version-script'. > >> > >> 3. It is picky about line endings. > >> Each symbol or directive must be on a line of it's own. > >> > >> Let's use make_sunver.pl from GCC to generate a version script that > works > >> correctly with the Solaris linker. It's function is to correctly expand > the > >> globs in the original generated version script. > >> --- > >> Makefile | 4 +- > >> common.mak | 2 +- > >> compat/solaris/make_sunver.pl | 331 > >> +++++++++++++++++++++++++++++++++++++++++ > >> configure | 10 +- > >> 4 files changed, 342 insertions(+), 5 deletions(-) > >> create mode 100755 compat/solaris/make_sunver.pl > >> > > > > Are there any technical concerns left from anybody for this patch? > > Not at all for me at least. The script probably might enjoy a gpl3 or > whatever it fits license header and it is good to go (I was planning to > look it up today but I hadn't had the time) > The original file in their repo doesn't have a license header -- how does this usually work with OSS licensing? Does it imply it follows the same license as the package it's attached to? For reference: https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/make_sunver.pl -- Sean McG. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
