On Wed, 14 Oct 2015 11:33:18 +0200
Vittorio Giovara <[email protected]> wrote:

>...

Patches 01-07,09,10 just do simple replacements of AVPicture usage (in
particular avpicture_... to av_image_... functions), and I can't find
anything wrong with them.

"[PATCH 08/11] lavc: Add data and linesize to AVSubtitleRect" is
slightly controversial. It looks like with that patch applied, the
AVPicture fields are just left to 0 when decoding a frame. I think
utils.c should at least set the AVPicture fields from the new fields
as long as the AVPicture member exists.

It's also a bit regrettable that this API change isn't used as an
opportunity to clean up the subtitle API in general, so API users have
to deal with yet another intermediary API change. But I guess it's ok,
because nobody knows yet what the new API should look like, even though
it has been discussed for years. It will probably take quite a bit
longer until this is done.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to