On 28/10/15 16:14, John Stebbins wrote:
> The code as it stands forwards whatever value frame_rate has through the
> filter chain.
> frame_rate is initialized to 0/0 when the AVFilterLink is av_mallocz'd
> and it can be initialized by buffersrc which sets a default value of
> 0/0.
> 
> So if you do not explicitly set frame_rate in buffersrc and no filter
> converts to a specific frame_rate (e.g. vf_fps), you will get 0/0 at the
> end of the filter chain.  There are filters (interlace, framepack, and
> yadif) that multiply input frame_rate.num or frame_rate.den by 2, but if
> input frame_rate is 0/0, it will still be 0/0 at the end of the filter
> chain.
> 
> Maybe you are just asking to keep the comment, but correct it to say "or
> 0/0 if unknown"?  That would make sense.

Pretty much. I'd make sure that comment and code match and do not do
something completely unexpected.

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to