On 31/10/15 17:37, Ganesh Ajjanagadde wrote: >>> +0: I'm not against it, an INT64_C() is needed for the >>> 0x89504e470d0a1a0a constant. >> >> True. I just copy and pasted this from ffmpeg's id3v2.c (similar case - >> cover art with wrong codec). Would a ULL suffix be good enough? > > Maybe useful to use libavcodec/png.h which #define's PNGSIG? This has > added benefit that changing (to e.g ULL) there will propagate to other > usages of this magic constant (such as libavformat/img2dec).
Moving the magic constants in a single place is possibly a point in the right direction, once the parsers overhaul appears and lands it would not be necessary to reference directly those constants though. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
