Quoting Vittorio Giovara (2015-11-18 01:46:39) > On Mon, Nov 16, 2015 at 3:28 PM, Alexandre Lision > <[email protected]> wrote: > > Hi, > > > > This patches bring support for video devices on OSX platform. > > Implementation is based on AVFoundation framework and is fully > > ARC (Automatic Reference Counting) compliant. > > > > It adds a new indev device, named avfoundation. > > > > AVOptions are: > > > > - list devices and and available pixel formats > > - video device selection by device unique ID > > - pixel format selection > > - video size selection > > - frame rate selection > > > > Usage examples: > > > > avconv -f avfoundation -i default out.avi > > avconv -f avfoundation -video_size 320x240 -framerate 15 -i default out.avi > > avconv -f avfoundation -i default out.avi > > avconv -f avfoundation -i -pixel_fromat bgra "DEVICEID" out.avi > > > > _______________________________________________ > > libav-devel mailing list > > [email protected] > > https://lists.libav.org/mailman/listinfo/libav-devel > > > Hey Alexandre ;) > > that's a nice set, let's start with a brief formal review > > 1/11 - I don't see anything obviously wrong, except I'd just drop > "initial" from the commit title, since it's probably definitive. > 2/11 - 4/11 could be squashed together, with all comments and TODO removed > 5/11 - the NSString pat should not be global > 6/11 - i think ok > 7/11 - just squash the changes in the appropriate patches, also don't > return 1 for success > 8/11 - don't adjust formatting because of adding a new element, just > fix it in the original patch > 9/11 - there are unneeded style changes > 8/11 - 11/11 could be squashed together under a more generic add options >
I have to ask why is this all not in a single patch (except maybe the first one) -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
