On 25/11/15 09:15, Thilo Borgmann wrote: > Hi folks, > > I wonder why you have done a reimplementation based on FFmpeg's device with > reduced features and OS support. Can you enlighten me?
The current implementation from Alexandre and the one from you are quite different: - This one references the devices using their stable names, your seems to use some index. - This one uses ARC, yours uses autorelease pools. - This one is just for video capture so far, yours is audio+video+screen_capture. Probably during his initial tries he used more code from yours, but the final version[1] I'm looking at keeps from your implementation just the pixel format -> CoreVideo formats table... Surely you should be credited in the patch, but yours and Alexandre's are quite different implementations and from what I can read, you wouldn't move to ARC so I guess their purposes are even different. lu [1] https://github.com/lu-zero/libav/commit/57755ba05b2878b1df552ab9a09cdbfadb2cdecc _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
