On Wed, Dec 2, 2015 at 1:53 PM, Andreas Cadhalpun <[email protected]> wrote: > On 30.11.2015 18:19, Vittorio Giovara wrote: >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. However they might very well be private, and, due to their >> absolute lack of documentation, they are hardly used in the wild. Despite >> being write-only there are options to initalize them, without any effect. >> >> There is spurious frame_bits which is used in aacenc, again in >> write-only mode, where it can be replaced with a simple local variable. >> >> Due to the extremely limited scope of use, inability to instruct >> applications how to use the values, and the presence of better means >> to share this kind of information (for example AV_PKT_DATA_QUALITY_FACTOR) >> these fields are removed from the global context. >> >> Signed-off-by: Vittorio Giovara <[email protected]> >> --- >> libavcodec/aacenc.c | 12 ++++++++---- >> libavcodec/avcodec.h | 17 ++++++++++++----- >> libavcodec/mpegvideo_enc.c | 15 ++++++++++++--- >> libavcodec/options_table.h | 2 ++ >> libavcodec/version.h | 3 +++ >> 5 files changed, 37 insertions(+), 12 deletions(-) > > avifile uses frame_bits [1], but probably meant to use bit_rate instead.
Nice finding > So this deprecating seems fine, but an entry in APIchanges would be nice. I'm hesitant about this, this removal, and the the changes from global to codec private (i have more in a branch) might pollute a little too much the file. Maybe we could do a single entry that list all the fields that got removed before release? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
