On Mon, Dec 7, 2015 at 2:21 AM, Martin Storsjö <[email protected]> wrote: > On Mon, 7 Dec 2015, Anton Khirnov wrote: > >> Quoting Ganesh Ajjanagadde (2015-12-07 00:44:37) >>> >>> On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato <[email protected]> wrote: >>> > On 06/12/15 20:30, Martin Storsjö wrote: >>> >> From: Ganesh Ajjanagadde <[email protected]> >>> >> >>> >> --- >>> >> libavformat/rtsp.c | 1 + >>> >> 1 file changed, 1 insertion(+) >>> >> >>> >> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c >>> >> index 2c616e8..4beb275 100644 >>> >> --- a/libavformat/rtsp.c >>> >> +++ b/libavformat/rtsp.c >>> >> @@ -2279,6 +2279,7 @@ static int sdp_read_header(AVFormatContext *s) >>> >> if (err) { >>> >> av_log(s, AV_LOG_ERROR, "getnameinfo: %s\n", >>> >> gai_strerror(err)); >>> >> err = AVERROR(EIO); >>> >> + av_dict_free(&opts); >>> >> goto fail; >>> >> } >>> >> ff_url_join(url, sizeof(url), "rtp", NULL, >>> >> >>> > >>> > Sounds good. >>> >>> As the author of the patch, I don't really mind how this is taken care >>> of. Also, I don't know if patches reveal this information completely. >>> >>> But it seems to me that "From: " is not an appropriate tag; the >>> "Signed-off-by" has been stripped away. Maybe even the --author= field >>> is incorrect, I don't know. >>> Vittorio seemed to handle it correctly: >>> https://lists.libav.org/pipermail/libav-devel/2015-September/072108.html. >> >> >> From is what sets the author, so you will be displayed as the author of >> the patch when it gets applied. Signed-off-by has no standard usage, >> different people use it differently. E.g. I think it's redundant to add >> it to my own patches, but I use it to tag commits that I pushed and >> perhaps modified, but did not author. > > > The interpretation of signed-off-by that I adhere to is that it means "I > approve of this particular version of the patch", like a more authoritative > version of reviewed-by and acked-by and the likes. Therefore, if somebody > changes a patch (in this case, only adjusts the commit message to match the > target project), previous sign-offs don't apply any longer. > > The author field is obviously kept as is, so it will be counted correctly > for statistics/whatever.
Thanks a lot for clarification. > > // Martin > > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
