Re: [libav-devel] [PATCH 1/3] avconv: Make the poll_filters() return value check uniform

[Luca Barbato]

On 02/01/16 18:33, Anton Khirnov wrote:

Quoting Luca Barbato (2016-01-02 14:43:12)

---
  avconv.c | 14 +++++---------
  1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/avconv.c b/avconv.c
index 57a3718..0410378 100644
--- a/avconv.c
+++ b/avconv.c
@@ -2556,16 +2556,12 @@ static int transcode(void)
          }

          ret = poll_filters();
-        if (ret < 0) {
-            if (ret == AVERROR_EOF || ret == AVERROR(EAGAIN)) {
-                continue;
-            } else {
-                char errbuf[128];
-                av_strerror(ret, errbuf, sizeof(errbuf));
+        if (ret < 0 && (ret != AVERROR_EOF || ret != AVERROR(EAGAIN))) {
+            char errbuf[128];
+            av_strerror(ret, errbuf, sizeof(errbuf));

-                av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", 
errbuf);
-                break;
-            }
+            av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", errbuf);
+            break;
          }

          /* dump report by using the output first video and audio streams */
--
2.6.2.402.g2635c2b.dirty

I don't see how is this useful.

Can be squashed with the following.

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel