On Tue, Dec 22, 2015 at 12:41 PM, Diego Biurrun <[email protected]> wrote: > On Thu, Dec 17, 2015 at 10:28:58AM -0500, Vittorio Giovara wrote: >> On Thu, Dec 17, 2015 at 7:28 AM, Diego Biurrun <[email protected]> wrote: >> > --- a/libavdevice/vfwcap.c >> > +++ b/libavdevice/vfwcap.c >> > @@ -382,8 +382,7 @@ static int vfw_read_header(AVFormatContext *s) >> > if(codec->pix_fmt == AV_PIX_FMT_NONE) { >> > codec->codec_id = vfw_codecid(biCompression); >> > if(codec->codec_id == AV_CODEC_ID_NONE) { >> > - av_log(s, AV_LOG_ERROR, "Unknown compression type. " >> > - "Please report verbose (-v 9) debug >> > information.\n"); >> > + avpriv_report_missing_feature(s, "This compression type"); >> >> this? > > Do you have a better suggestion?
How about 'Compression type %d', biCompression >> >> Are you absolutely sure that the bounds of the codecs/formats I >> highlighted above aren't actually features that the standard or the >> format explicitly disallows? For example in txd there might be only >> the currently supported formats, and all the others should be >> considered as an error. > > No, as I don't know all the formats in detail. I just located places > that returned AVERROR_PATCHWELCOME w/o reporting a missing feature or > requesting a sample and did more or less the same manually instead. It really sounds to me that the ones I pointed out above should be left out. >> Likewise, many of this error messages could >> probably be replaced with request_sample rather than missing_feature, >> especially the ones related to version checking. > > Probably. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
