On Thu, Jan 7, 2016 at 11:04 PM, Clément Bœsch <[email protected]> wrote: > On Thu, Jan 07, 2016 at 06:14:24PM -0300, James Almer wrote: >> On 1/6/2016 6:13 AM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2016-01-04 16:40:23) >> >> From: Clément Bœsch <[email protected]> >> >> >> >> This macro is faster when shift is constant. >> >> >> >> Signed-off-by: Vittorio Giovara <[email protected]> >> >> --- >> >> This macro is needed by the cfhd decoder and it slightly improves >> >> performance where it is used. >> >> Vittorio >> >> > TBH, nowadays I considered it sufficiently safe, but given how often end > users can end up using it, I wanted to make sure it was designed as > appropriate. > > Note1: we actually recently had an issue with __builtin_constant_p and > some assembly, unrelated to this macro though. > > Note2: the range is actually larger than documented, see ff recent changes
Thanks for your feedback, I'll send an amended version. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
