On Thu, Jan 21, 2016 at 11:38:20AM -0500, Vittorio Giovara wrote: > On Thu, Jan 21, 2016 at 3:17 AM, Diego Biurrun <[email protected]> wrote: > > On Wed, Jan 20, 2016 at 10:48:12AM -0500, Vittorio Giovara wrote: > >> On Wed, Jan 20, 2016 at 5:10 AM, Diego Biurrun <[email protected]> wrote: > >> > On Tue, Jan 19, 2016 at 07:45:25PM -0500, Vittorio Giovara wrote: > >> >> --- a/libavcodec/eatqi.c > >> >> +++ b/libavcodec/eatqi.c > >> >> @@ -35,69 +35,177 @@ > >> >> > >> >> +/* Based off mpeg1_decode_block_intra from mpeg12dec.c */ > >> > > >> > s/Based off/Duplicated from/ > >> > >> it's not strictly duplicated as it has some simplifications, but ok > > > > Well, one "simplification" I noticed was mixing declarations and statements, > > so ... > > > >> > I don't see this as an improvement. > >> > >> why? > > > > Because it's code duplication, pure and simple. > > you can't be seriously comparing the mpegvideo detangling and a > complete decoder deduplication (mpeg1) to the addition of a single > relatively small function
Yes, I can. You are turning an increase in size on the library level for one obscure config (eatqi w/o mpeg1) to actual code duplication. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
