On Mon, Oct 26, 2015 at 09:08:35PM +0100, Luca Barbato wrote:
> That makes possible to use --toolchain=asan.

Allows using ..

> --- a/configure
> +++ b/configure
> @@ -2641,42 +2641,49 @@ set >> $logfile
>  case "$toolchain" in
>      clang-asan)
>          cc_default="clang"
> -        add_cflags  -fsanitize=address
> -        add_ldflags -fsanitize=address
>      ;;
>      clang-tsan)
>          cc_default="clang"
> -        add_cflags  -fsanitize=thread -pie
> -        add_ldflags -fsanitize=thread -pie
>      ;;
>      clang-usan)
>          cc_default="clang"
> -        add_cflags  -fsanitize=undefined -O1
> -        add_ldflags -fsanitize=undefined
> +        add_cflags -O1
>      ;;
>      gcc-asan)
>          cc_default="gcc"
> -        add_cflags  -fsanitize=address
> -        add_ldflags -fsanitize=address
>      ;;
>      gcc-tsan)
>          cc_default="gcc"
> -        add_cflags  -fsanitize=thread -pie -fPIC
> -        add_ldflags -fsanitize=thread -pie -fPIC
> +        add_cflags  -fPIC
> +        add_ldflags -fPIC
>      ;;
>      gcc-usan)
>          cc_default="gcc"
> -        add_cflags  -fsanitize=undefined
> -        add_ldflags -fsanitize=undefined
>      ;;
>      valgrind-massif)
> -        target_exec_default="valgrind"
>          target_exec_args="--alloc-fn=av_malloc --alloc-fn=av_mallocz"
>      ;;
>      valgrind-memcheck)
> -        target_exec_default="valgrind"
>          target_exec_args="--track-origins=yes --leak-check=full"
>      ;;
> +esac
> +
> +case "$toolchain" in
> +    *asan)
> +        add_cflags  -fsanitize=address
> +        add_ldflags -fsanitize=address
> +    ;;
> +    *tsan)
> +        add_cflags  -fsanitize=thread -pie
> +        add_ldflags -fsanitize=thread -pie
> +    ;;
> +    *usan)
> +        add_cflags  -fsanitize=undefined
> +        add_ldflags -fsanitize=undefined
> +    ;;
> +    valgrind*)
> +        target_exec_default="valgrind"
> +    ;;
>      msvc)
>          # Check whether the current MSVC version needs the C99 converter.
>          # From MSVC 2013 (compiler major version 18) onwards, it does 
> actually

Unfortunately there is no fallthrough in POSIX shell like in bash.
Splitting the case block in two parts is ugly though.  I think embedded
case blocks would be cleaner even if a few lines longer.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to