On 06/02/16 17:37, Diego Biurrun wrote:
> On Sat, Feb 06, 2016 at 01:03:45PM +0100, Luca Barbato wrote:
>> And move x264-specific printing in a separate function.
>
> to a
Amended, thank you.
>> --- a/libavcodec/h264_sei.c
>> +++ b/libavcodec/h264_sei.c
>> @@ -213,30 +215,92 @@ static int decode_registered_user_data(H264Context *h,
>> int size)
>> +static void safe_read(GetBitContext *gb, uint8_t *buf, int size)
>
> size_t size maybe?
The input is always int, I wouldn't use size_t when it not necessary.
>
>> +static int decode_x264_version(H264Context *h, int size)
>> +{
>> + int build = 0, i = 0;
>> + uint8_t *x264_string;
>
> char*? It's a string after all..
Sure.
>
>> + uint8_t uuid[16];
>>
>> + av_log(h->avctx, AV_LOG_DEBUG,
>> + "uuid 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x "
>> + "0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n",
>> + uuid[0], uuid[1], uuid[2], uuid[3],
>> + uuid[4], uuid[5], uuid[6], uuid[7],
>> + uuid[8], uuid[9], uuid[10], uuid[11],
>> + uuid[12], uuid[13], uuid[14], uuid[15]);
>
> PRIx8 to print uint8_t.
Sure.
I'll merge with the change mentioned tomorrow and roll the hevc
equivalent to be the same.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
