On Mon, Feb 08, 2016 at 10:17:05AM +0100, Luca Barbato wrote:
> --- a/libavcodec/dnxhddata.c
> +++ b/libavcodec/dnxhddata.c
> @@ -1203,3 +1203,26 @@ int ff_dnxhd_find_cid(AVCodecContext *avctx, int
> bit_depth)
> +void ff_dnxhd_list_cid(AVCodecContext *avctx)
> +{
> + av_log(avctx, AV_LOG_INFO,
> + "cid %d %dx%d %dbits %s bit rates",
> + cid->cid,
> + cid->width, cid->height,
> + cid->bit_depth,
> + cid->interlaced ? "interlaced " :
> + "progressive");
width and height are unsigned, use %u.
I think it would be more readable comma-separated.
> --- a/libavcodec/dnxhdenc.c
> +++ b/libavcodec/dnxhdenc.c
> @@ -289,14 +289,15 @@ static av_cold int dnxhd_encode_init(AVCodecContext
> *avctx)
> av_log(avctx, AV_LOG_ERROR,
> - "pixel format is incompatible with DNxHD\n");
> + "pixel format is incompatible with DNxHD, use yuv422p or
> yuv422p10.\n");
> av_log(avctx, AV_LOG_ERROR,
> - "video parameters incompatible with DNxHD\n");
> + "video parameters incompatible with DNxHD, available
> CIDs:\n");
Capitalize the first word while you're at it.
LGTM otherwise
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
