On Mon, Dec 15, 2014 at 7:51 AM, Luca Barbato <[email protected]> wrote: > On 08/12/14 15:27, Vittorio Giovara wrote: >> >> From: Marton Balint <[email protected]> >> >> Improves compatibility with XDCAM HD formats. It has been set for >> a long time in ffmbc. >> >> Reviewed-by: Michael Niedermayer <[email protected]> >> Signed-off-by: Marton Balint <[email protected]> >> --- >> libavcodec/mpeg12enc.c | 3 ++- >> tests/ref/lavf/gxf | 2 +- >> tests/ref/lavf/mpg | 2 +- >> tests/ref/lavf/mxf | 2 +- >> tests/ref/lavf/ts | 2 +- >> tests/ref/vsynth/vsynth1-mpeg1 | 2 +- >> tests/ref/vsynth/vsynth1-mpeg1b | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2 | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-422 | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-idct-int | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-ilace | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-ivlc-qprd | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-thread | 2 +- >> tests/ref/vsynth/vsynth1-mpeg2-thread-ivlc | 2 +- >> tests/ref/vsynth/vsynth2-mpeg1 | 2 +- >> tests/ref/vsynth/vsynth2-mpeg1b | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2 | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-422 | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-idct-int | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-ilace | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-ivlc-qprd | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-thread | 2 +- >> tests/ref/vsynth/vsynth2-mpeg2-thread-ivlc | 2 +- >> 23 files changed, 24 insertions(+), 23 deletions(-) >> >> diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c >> index 8f9292f..4547a38 100644 >> --- a/libavcodec/mpeg12enc.c >> +++ b/libavcodec/mpeg12enc.c >> @@ -324,7 +324,8 @@ static void >> mpeg1_encode_sequence_header(MpegEncContext *s) >> put_bits(&s->pb, 1, 1); >> put_bits(&s->pb, 6, (uint32_t)((time_code / fps) % 60)); >> put_bits(&s->pb, 6, (uint32_t)((time_code % fps))); >> - put_bits(&s->pb, 1, !!(s->flags & CODEC_FLAG_CLOSED_GOP) || >> s->intra_only); >> + put_bits(&s->pb, 1, !!(s->flags & CODEC_FLAG_CLOSED_GOP) || >> + s->intra_only || !s->gop_picture_number); >> put_bits(&s->pb, 1, 0); // broken link >> } >> } > > > Probably ok, would be safer to make sure the first gop is really closed > thought?
umh not sure about it, do you think it'd be better to add additional logic elsewhere? -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
