On Fri, Feb 26, 2016 at 09:48:12AM +0000, Mark Thompson wrote: > On 26/02/16 08:51, Diego Biurrun wrote: > > On Thu, Feb 25, 2016 at 11:48:50PM +0000, Mark Thompson wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -1704,6 +1704,7 @@ CONFIG_EXTRA=" > >> texturedspenc > >> tpeldsp > >> + vaapi_recent > >> vc1dsp > >> videodsp > >> @@ -4676,6 +4677,10 @@ enabled vaapi && enabled xlib && > >> enable vaapi_x11 > >> > >> +enabled vaapi && > >> + check_code cc "va/va.h" "vaCreateSurfaces(0, 0, 0, 0, 0, 0, 0, 0)" && > >> + enable vaapi_recent > > > > How recent? If it's old enough we might just drop support for old vaapi. > > After > <https://cgit.freedesktop.org/libva/commit/?id=e1d3569778a6662a2d8b97180c790e862a3926be>. > This changed when encode support was added at VAAPI version 0.34 / libva > 1.2.0. > > Some still-supported distributions such as Debian Wheezy (oldstable) and > Ubuntu > 12.04 LTS contain an older version, and the current decoder hwaccel code does > work on it so it seemed preferable to add a new detected configure option to > avoid breaking that.
Given that it will take some time for this code to mature and land (probably after release 12) I think we can ignore these distros and save us some compat hassles. > > "recent" is a tad nondescriptive. What is the feature or API change you > > need? > > The necessary feature is vaCreateSurfaces() which takes surface attribute > arguments (hence detected as the function taking eight arguments, rather than > six as it did before the change). > > "VAAPI_SURFACE_ATTRIBUTES"? Much better; "recent" is going to sound odd in a year or two already. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
