On Mon, Mar 07, 2016 at 11:21:45PM +0000, Mark Thompson wrote:
> --- /dev/null
> +++ b/libavutil/hwcontext_vaapi.c
> @@ -0,0 +1,822 @@
> +
> +    // On current Intel drivers, derive gives you memory which is very slow
> +    // to read normally.  Assume for now that a user who asks for read access
> +    // but doesn't explicitly request direct mapping is not going to be
> +    // optimised for such, so don't use derive in that case.

Please specify what "current" is.  In a year or two, nobody will have a
clue whether or not this comment is still relevant.

> +
> +  fail:

Please move goto labels to the first column.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to