On Tue, Mar 22, 2016 at 12:06 AM, Janne Grunau <[email protected]> wrote:
>> +        GetByteContext gbc;
>> +        PutByteContext pbc;
>> +        uint8_t escaped_buf[256];
>
> that looks plenty for sane SPS' but it should be easy to come up with
> scaling lists which exceeds this size (up to 6 * 16 + 2 * 64 signed
> exp-golomb values for [-128,127]). Since this is a codepath for not spec
> complient streams I'd just add a warning and return an error if the
> escaped_buffer is too small.
>

Increasing the buffer a bit to hold enough bits for any possible valid
SPS shouldn't really hurt anything, so why build a fallback but then
limit it to something arbitrary like this?

- Hendrik
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to