Quoting Diego Biurrun (2016-03-23 15:29:10)
> On Wed, Mar 23, 2016 at 09:23:41AM +0100, Janne Grunau wrote:
> > On 2016-03-20 10:01:44 +0100, Anton Khirnov wrote:
> > > ---
> > > configure | 14 ++++++
> > > libavcodec/bitstream_filters.c | 37 +--------------
> > > libavformat/protocols.c | 105
> > > +----------------------------------------
> > > 3 files changed, 16 insertions(+), 140 deletions(-)
> > >
> > > diff --git a/configure b/configure
> > > index ba1fd47..33aa22f 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -5246,6 +5246,20 @@ cp_if_changed $TMPH libavutil/avconfig.h
> > >
> > > test -n "$WARNINGS" && printf "\n$WARNINGS"
> > >
> > > +# generate the lists of enabled components
> > > +print_enabled_components(){
> > > + file=$1
> > > + shift
> > > + echo "" > $TMPH
> > > + for c in $*; do
> > > + enabled $c && printf "&ff_%s,\n" $c >> $TMPH
> > > + done
> > > + cp_if_changed $TMPH $file
> > > +}
> > > +
> > > +print_enabled_components libavcodec/bsf_list.c $BSF_LIST
> > > +print_enabled_components libavformat/protocol_list.c $PROTOCOL_LIST
> >
> > could we not call the files .c if they are not valid C files. I'd
> > suggest genereting the whole arrays.
> >
> > The naming of the files btw broke the make reminder for re-running
> > configure. The names should have started with 'all'.
>
> Nor does it modify the distclean target or .gitignore. Wasn't that
> mentioned in a review round?
I didn't yet send a new patch.
--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
