On Tue, May 03, 2016 at 03:39:18PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-05-03 15:07:55) > > On Tue, May 03, 2016 at 02:56:08PM +0200, Anton Khirnov wrote: > > > --- /dev/null > > > +++ b/libavutil/hwcontext_dxva2.c > > > @@ -0,0 +1,291 @@ > > > + > > > +#include <windows.h> > > > + > > > +#ifdef _WIN32_WINNT > > > +#undef _WIN32_WINNT > > > +#endif > > > +#define _WIN32_WINNT 0x0600 > > > > This is duplicated in avconv_dxva2.c and 90% similarly in a few other > > places. Time to refactor? > > I understand this defines the version of windows that's required by this > code, which depends on the specific code in question.
Yes, but I assume that avconv_dxva2.c requiring the same is not a coincidence. Thus I think it would make sense to declare this in a common header or some such. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
