On 09/05/16 14:40, Derek Buitenhuis wrote:
> On 5/7/2016 11:35 AM, Alexandra Hájková wrote:
>> - if (get_bits_long(gb, 32) != MKBETAG('A','L','S','\0'))
>> + if (bitstream_read_narrow(bc, 32) != MKBETAG('A','L','S','\0'))
>
> To me, this change pretty much highlights how confusing the new vague
> names are. I can't even tell if this change is correct without reading
> the source for "bitstream_read_narrow".
>
compared to
bitstream_read(bc, 32);
and
bitstream_read_32(bc, 32);
Only the latter helps you a little more.
At least bitstream.h is fully documented so it does not require you to
use the preprocessor to see what is going on =)
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
